libnut icon indicating copy to clipboard operation
libnut copied to clipboard

Add OEM keys for azerty only keys

Open Raraph84 opened this issue 1 year ago • 1 comments

Adding support for Windows azerty oem keys (like <> key) -> See here https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes

Raraph84 avatar Aug 31 '24 16:08 Raraph84

Hi @Raraph84 👋

thanks for opening this PR. To be honest, I have mixed feelings about it.

Most of the introduced constants are already defined. Since linbnut defaults to the US ANSI layout the respective constants are directly assigned to their keys. Additionally, naming is very generic and Windows specific, which does not translate well to other platforms.

Docs state a clear mapping only for US ANSI, so what does oem_1 correspond to on e.g. a German ISO layout?

One thing I see is that for non-US-ANSI layouts a physical key is missing (OEM_102), I'll have to think about how to best integrate all physical keys.

But overall, I'd object to merge this PR for said reasons.

Best regards

Simon

s1hofmann avatar Sep 02 '24 20:09 s1hofmann