Release Planner
Context
Resolves #3689
Implementation
- Display planner in Navbar on all devices (Including mobile devices which didn't show the planner in the past, was it intended or was it a bug?)
- Remove
currentTestsinBetaToggle - Remove beta feedback for Planner page
| Description | Before | After |
|---|---|---|
| No more beta toggle | ||
| Planner tab in mobile navbar | ||
| No more leave feedback button |
Other Information
Since there's no more test, the beta test toggle in settings doesn't appear by default anymore. Is this intended?
Noticed that the plan to take, exemptions and trash section overflows for mobile. Should we fix it first before releasing this to public? We can make another issue for it, because it's UI related I think we need some discussion for it.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| nusmods-export | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 30, 2024 1:44pm |
| nusmods-website | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 30, 2024 1:44pm |
@wr1159 is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel.
@nusmodifications first needs to authorize it.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 54.75%. Comparing base (
2d4743d) to head (cd217db). Report is 3 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| website/src/views/settings/BetaToggle.tsx | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #3696 +/- ##
==========================================
+ Coverage 53.87% 54.75% +0.87%
==========================================
Files 274 274
Lines 6032 6043 +11
Branches 1449 1452 +3
==========================================
+ Hits 3250 3309 +59
+ Misses 2782 2734 -48
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'll approve this pending merge conflicts and stuff, but merging will be on hold for now due to some internal requirements with NUS. We expect to be able to merge in around a month or so 🙏
LGTM, thanks!