numerox icon indicating copy to clipboard operation
numerox copied to clipboard

Fix failing tests due to data changes

Open jparyani opened this issue 6 years ago • 5 comments

See Travis for what's failing.

You can run tests locally by doing:

python ci/test-installed-numerox.py

jparyani avatar Jul 12 '19 18:07 jparyani

Hi @jparyani, I'd like to help out with this issue.

How can I build this repo locally?

csp197 avatar Jul 12 '19 22:07 csp197

To install the local repo, all you have to do is run:

pip install -e .

After that succeeds, run:

python ci/test-installed-numerox.py

to see all the failing tests.

jparyani avatar Jul 12 '19 22:07 jparyani

There are 55 errors and 2 failures, and I've fixed the 2 failures. I'm trying to resolve the errors now :)

csp197 avatar Jul 13 '19 00:07 csp197

@jparyani - I've added a commit which takes care of the failures, but there are still quite a bit of errors. A lot of them deal with the ramifications of the new active kazutsugi tournament, as well as rendering the rest of the tournaments inactive.

csp197 avatar Jul 13 '19 03:07 csp197

Alright, if you’ve reached a good partial stopping point, feel free to create a PR.

jparyani avatar Jul 13 '19 03:07 jparyani