nuke icon indicating copy to clipboard operation
nuke copied to clipboard

SqlPackage CLI Wwrpper for Nuke

Open JinsPeter opened this issue 2 years ago • 5 comments

I confirm that the pull-request:

  • [x] Follows the contribution guidelines
  • [x] Is based on my own work
  • [x] Is in compliance with my employer

JinsPeter avatar Jun 30 '23 05:06 JinsPeter

Typo in filename, and markdown file should be removed.

matkoch avatar Jul 25 '23 01:07 matkoch

There are a lot of properties that are unused, ie. don't define a format. What's their purpose?

matkoch avatar Jul 25 '23 01:07 matkoch

There are a lot of properties that are unused, ie. don't define a format. What's their purpose?

Please correct me if wrong, I think you are referring to the delegates array. The purpose of such fields is to be used as KeyValue pair in the format {Key}={Value} Which is defined in the parent json's itemFormat property

JinsPeter avatar Jul 25 '23 07:07 JinsPeter

Ah, right! I didn't see that. FYI, if different tasks share a lot of common properties, you could use something like this: https://github.com/nuke-build/nuke/blob/develop/source/Nuke.Common/Tools/ReSharper/ReSharper.json#L14

matkoch avatar Jul 25 '23 07:07 matkoch

Thanks, What I did was a Search an replace migration from actual markdown code files in https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-deploy-drift-report.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-download.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-export.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-extract.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-for-azure-synapse-analytics.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-pipelines.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-publish.md, https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/tools/sqlpackage/sqlpackage-script.md.

I tried some manual effort to group the common properties and figures this caused too much effort. Thats why I left it as is.

JinsPeter avatar Jul 25 '23 07:07 JinsPeter