neosync
neosync copied to clipboard
Bug: MySQL WHERE clause column qualification fails when column is on right side of comparison operator.
Bug description
MySQL WHERE clause column qualification fails when the column is on the right side of a comparison operator. This causes the query to be generated incorrectly as the table alias is not properly added to the column name.
For example, with the WHERE clause 100 > user_id, the generated query incorrectly shows:
WHERE 100 > user_id
Instead of the correct:
WHERE 100 > t_09a0eed1cbbe07ca.user_id
This only affects MySQL queries. PostgreSQL queries work correctly regardless of column position.
How to reproduce
- Use MySQL driver with a query having a WHERE clause
- Put the column name on the right side of comparison (e.g.,
100 > user_id) - Run the query builder
- Observe that the generated query has unqualified column name
Minimal reproduction test:
func Test_BuildQuery_MySQLColumnQualification(t *testing.T) {
t.Run("mysql column on right", func(t *testing.T) {
assert.Equal(t,
"SELECT `orders`.`order_id`, `orders`.`user_id` FROM `public`.`orders` AS `orders` INNER JOIN `public`.`users` AS `t_09a0eed1cbbe07ca` ON (`t_09a0eed1cbbe07ca`.`user_id` = `orders`.`user_id`) WHERE 100 > t_09a0eed1cbbe07ca.user_id ORDER BY `orders`.`order_id` ASC",
buildOrdersUsersSubsettingQuery(t, "100 > user_id", sqlmanager_shared.MysqlDriver),
)
})
}
Environment
- MySQL driver
- Go version: latest
- OS: any
Additional context
- Only affects MySQL queries
- Only happens when column is on right side of comparison
- PostgreSQL queries work correctly in all cases due to different AST traversal approach
I've submitted a PR to fix this issue: #3495
cc @nickzelei @evisdrenova
Thanks! Will review!