clj-github icon indicating copy to clipboard operation
clj-github copied to clipboard

Append the path to the github url with slash when necessary

Open phmeier-nubank opened this issue 4 years ago • 5 comments

  • Join path with baseurl using a / where necessary

phmeier-nubank avatar Jul 09 '21 08:07 phmeier-nubank

Join path with baseurl using a / where necessary

This is to avoid having to pass {:path "/path"} ?

gabrielgiussi avatar Jul 09 '21 15:07 gabrielgiussi

Allow to specify the Content-Type and Authorization request headers manually

Do you have a use case for this already?

gabrielgiussi avatar Jul 09 '21 15:07 gabrielgiussi

I'm ok with allowing overwriting the headers but would like to better understand what's the use case for allowing the path without the initial slash.

rfhayashi avatar Jul 12 '21 13:07 rfhayashi

Allow to specify the Content-Type and Authorization request headers manually

Do you have a use case for this already?

I'm going to update the PR desc, this was part of the PR initially until I removed it. I had trouble with the github authorization before and specifying the Authorization header manually was what did it for me. Now that this code is no longer included the PR desc actually does not make sense.

phmeier-nubank avatar Jul 14 '21 09:07 phmeier-nubank

Allow to specify the Content-Type and Authorization request headers manually

Do you have a use case for this already?

I'm going to update the PR desc, this was part of the PR initially until I removed it. I had trouble with the github authorization before and specifying the Authorization header manually was what did it for me. Now that this code is no longer included the PR desc actually does not make sense.

I'm going to remove the tests as well.

phmeier-nubank avatar Jul 14 '21 09:07 phmeier-nubank