node-efficientnet icon indicating copy to clipboard operation
node-efficientnet copied to clipboard

feature: Hebrew language support

Open ntedgi opened this issue 4 years ago β€’ 0 comments

today we only support English and Chinese label translations

translate image net labels to Hebrew take https://github.com/ntedgi/node-efficientnet/blob/main/misc/en.json translate it to Hebrew using some machine or by hand

  • add it to /misc folder

  • add the ENUM and corresponding case under EfficientNetLanguageProvider

  • add minimal test for example :


test("EfficientNetLanguageProvider - check chinese translation file", (done) => {
  const chineseProvider = new EfficientNetLanguageProvider(
    EfficientNetLableLanguage.CHINESE
  );
  chineseProvider
    .load()
    .then(() => {
      const result = chineseProvider.get(0);
      expect(result).toBeDefined();
      expect(result).toEqual("丁鲷");
      done();
    })
    .catch((error) => done(error));
});
  • update readme file add the language support to https://github.com/ntedgi/node-efficientnet#multilingual-status

ntedgi avatar Mar 28 '21 08:03 ntedgi