tiny11builder icon indicating copy to clipboard operation
tiny11builder copied to clipboard

Code littered with errors

Open code-leech opened this issue 3 months ago • 4 comments

I ran ./tiny11maker.ps1 -ISO E -SCRATCH D (D is an NTFS formatted USB stick, E is obviously the mounted ISO). First off, I got an error saying that "D" (no colon) is an invalid letter. I tried changing the letter of my drive. Nothing. What's even more annoying, is that every time there is an error in your script... IT DOES NOT STOP, IT JUST CONTINUES!

Continuing on from there, since the ScratchDisk is NOT PROPERLY SET, it gives "missing file" errors when deleting/copying files FROM THE E: DRIVE

Also PLEASE make the instructions clearer in README.md.

Finally a question that has been bugging my programmer mind for eternity: WHY POWERSHELL?

code-leech avatar Oct 08 '25 17:10 code-leech

Hi @code-leech !

  • I think you don't use the last script version please retry with the one on the main page not in the release section. If it doesn't work, please provide the log file it can help us.
  • What did you find not clear in the instructions?
  • Idk, why not? It's native and can do all needed thing, for a pure windows workflow i find logic to use it.

Miiraak avatar Oct 13 '25 16:10 Miiraak

I also find the instructions unclear, there is no explanation what -SCRATCH is and it just says <letter> which is described in the next step as the iso image drive so I put that as it was the only instruction, this resulted in a an endless amount of errormessages trying to write to a read only iso drive...

dyster avatar Oct 19 '25 14:10 dyster

I have created pull-request #488 with some additions to the script step (and fixed the numbering)

dyster avatar Oct 19 '25 15:10 dyster

If you're a programmer you should be able to read the script and figure it out right? I'm in the same boat which is why I read it, the code is not 'littered with errors' it has an inclear instruction.

Regarding asking why you would use powershell to make use of DISM for imaging and call the OS API, you might want to try doing this yourself. It's very quickly apparent. If you're asking why over cmd, it's because the store applications are significantly easier to remove.

Can't we just be grateful we're not writing this script out ourselves?

Bensterriblescripts avatar Nov 04 '25 06:11 Bensterriblescripts