Nick Ripley
Nick Ripley
Would it be possible to measure multiple events simultaneously by creating a `PerfProfile` for every event of interest? Alternatively, by giving `PerfProfile` a method like `func (*PerfProfile) MeasureEvent(name string, period...
Could you share the rationale behind this? Is there a CVE or something? Also, have we considered the implications of this upgrade, for example on our internal repos? From past...
> @nsrip-dd Is this PR alive too? Nope! I'll close it.
> @nsrip-dd Is this PR alive? We can close it for now. I'll reopen/recreate if I actually get back to this.
Closing in favor of #403
> Unfortunately I wasn't able yet to figure out what's up with the failing tests... I've ping'd @danielsn to see if he has any idea on how to fix those....
TBH I'm not sure it makes much sense to me for this library. As it stands, `DD_PROFILING_ENABLED=true` would not be sufficient, on its own, to enable profiling. You need to...
Half-baked idea: Maybe it'd be better if we had a simpler API for setting up profiling? Like, you underscore-import it and it adds an `init` function to start profiling, guarded...
> The default value of DD_PROFILING_ENABLED is true. If the user hasn't set it explicitly, the code will be profiled if profiler.Start() is called in the application code, and it...