ns1-python icon indicating copy to clipboard operation
ns1-python copied to clipboard

Fixes #92 #93 & #94

Open steffenschumacher opened this issue 3 years ago • 5 comments

Fix loadScope so it accepts only the required scope id Fix rest.ipam.xyz classes so they accept the fields listed on the current API docs Fix rest.ipam.addresses.search so it works pr API docs Add expand method to rest.ipam.scopegroups

Running tests in 3.9 fails helpers::test_singleton_mixin_with_concurrency but I doubt this is my doing..

steffenschumacher avatar Mar 12 '22 18:03 steffenschumacher

@modiharsh04 this is still good to go?

cbertinato avatar Jun 27 '22 15:06 cbertinato

I haven't tested PR with pulling the code in, but this does look good to me change wise.

modiharsh04 avatar Jun 27 '22 16:06 modiharsh04

I guess so much time has passed that the APIs might have changed again 😏

steffenschumacher avatar Jun 27 '22 17:06 steffenschumacher

AFAIK, no api was changed since the last commit here which is on March 12, 2022.

modiharsh04 avatar Jun 27 '22 18:06 modiharsh04

@eravin-ns1 can you please merge and make a release?

cbertinato avatar Dec 19 '22 23:12 cbertinato