noweb icon indicating copy to clipboard operation
noweb copied to clipboard

Apply compile flags consistently

Open turboencabulator opened this issue 3 years ago • 3 comments

Another piece of #10:

  • Update compile flags: Add $(LDFLAGS) when linking, add a missing $(CFLAGS) to contrib/norman/numarkup, move flags from $(CC) to $(CFLAGS).
  • Having -Werror in the default $(CFLAGS) causes the fakepretty build to fail. Fix up those warnings/errors, and sort a few parts of the Makefile so that fakepretty (and nwmktemp) is on par with the other targets in src/c.

turboencabulator avatar May 28 '22 19:05 turboencabulator

Should CFLAGS and LDFLAGS be mentioned in src/INSTALL?

nrnrnr avatar Jun 22 '22 22:06 nrnrnr

I've added a mention of CFLAGS and a couple other variables to the installation steps (latest commit), rebased on your latest commit, and fixed a couple issues with gitversion.c/.o.

turboencabulator avatar Jun 26 '22 08:06 turboencabulator

Thanks! I blew my noweb budget yesterday, but I'll hope to get back to this one soon.

nrnrnr avatar Jun 26 '22 15:06 nrnrnr

In the following line,

	(cd $(LIBSRC) && $(MAKE) "ICONT=$(ICONT)" "ICONC=$(ICONC)" LIB=$(LIB) BIN=$(BIN) install)

why are the Icon assignments quoted but the LIB and BIN assignments not quoted?

nrnrnr avatar Jun 27 '23 14:06 nrnrnr

In the following line,

	(cd $(LIBSRC) && $(MAKE) "ICONT=$(ICONT)" "ICONC=$(ICONC)" LIB=$(LIB) BIN=$(BIN) install)

why are the Icon assignments quoted but the LIB and BIN assignments not quoted?

I think it was primarily for attaching flags to the Icon commands (the ICONC=iconc -f l example in src/INSTALL) rather than dealing with paths containing spaces. It probably wouldn't hurt to quote everything everywhere to handle paths with spaces, but that does make everything ugly.

turboencabulator avatar Jun 28 '23 06:06 turboencabulator

OK, let's leave it as is, then.

nrnrnr avatar Jun 28 '23 16:06 nrnrnr