sofie-core icon indicating copy to clipboard operation
sofie-core copied to clipboard

fix: move setup of process and logging of Gateways to server-core-integration

Open nytamin opened this issue 3 years ago • 1 comments

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix

  • What is the current behavior? (You can also link to an open issue here) There are issues in mos-gateway which causes som logging to not work. Examples:

const err = new Error('Error')
logger.error(err)
logger.error('here's my error', err, err.stack)
logger.info('these', 'are', 'many', 'arguments')

Because MOS-gateway and Playout-gateway have duplicates of the code setting up logging, they don't always behave the same.

  • What is the new behavior (if this is a feature change)? The examples above work now, and works the same between MOS-gw and Playout-gw.

  • Other information:

Status

  • [ ] Code documentation for the relevant parts in the code have been added/updated by the PR author
  • [ ] The functionality has been tested by the PR author
  • [ ] The functionality has been tested by NRK

nytamin avatar Aug 11 '22 11:08 nytamin

Tested. Works.

jesperstarkar avatar Aug 11 '22 13:08 jesperstarkar

Closing this PR due to inactivity. We'll likely do another try at unifying this logging at a later time.

nytamin avatar Oct 26 '22 10:10 nytamin