weasel icon indicating copy to clipboard operation
weasel copied to clipboard

Doesn't work with recent clojurescript; goog.net.WebSocket constructor changed

Open robgssp opened this issue 4 years ago • 1 comments

src/cljs/weasel/impls/websocket.cljs:23 needs to wrap its arguments in an object, per https://google.github.io/closure-library/api/goog.net.WebSocket.html. Currently the code TypeError's on ClojureScript 1.10.773.

robgssp avatar Feb 24 '21 23:02 robgssp

Yeah, please fix this.

until then, 1.10.520 works fine

Edit: After looking into it a bit more, it seems to me that we just need to bump weasel's clojurescript to 1.10.773, which uses closure lib v20210302. And it does not need it in an object.

https://github.com/google/closure-library/blob/169a1d1d25cbe04eef4a395c084e59ae927f1438/closure/goog/net/websocket.js#L52

alechstong avatar Mar 23 '21 14:03 alechstong