Satisfying functions don't provide an option to also compare build meta

[pflannery]

Similar to the issue #276.

When using the maxSatisfying function where the latest version includes build meta data then maxSatisfying returns a lesser version.

Example

const options = { loose: true, includePrerelease: true };
const releases = [
  '0.1.4',
  '0.1.4+1',
  '0.1.4+2',
  '0.1.4+3',
  '0.1.5',
  '0.1.5+1',
  '0.1.5+2',
];

// returns 0.1.5
maxSatisfying( releases, '0.1.5+2', options );

I can't find a way to utilize the newer compareBuild function when using maxSatisfying.

Is it possible if we can have an additional option like includeBuild so that we can compare builds?

[ailadas]

Similar to the issue #276.

When using the maxSatisfying function where the latest version includes build meta data then maxSatisfying returns a lesser version.

Example

const options = { loose: true, includePrerelease: true };
const releases = [
  '0.1.4',
  '0.1.4+1',
  '0.1.4+2',
  '0.1.4+3',
  '0.1.5',
  '0.1.5+1',
  '0.1.5+2',
];

// returns 0.1.5
maxSatisfying( releases, '0.1.5+2', options );

I can't find a way to utilize the newer compareBuild function when using maxSatisfying.

Is it possible if we can have an additional option like includeBuild so that we can compare builds?

[jonmountjoy]

@pflannery VersionLens already provides a prompt to install the latest version, which works well, and the problem seems only in the comparison of the version installed with the result from maxSatisying. Is it possible for you to add an extra check on the output of maxSatisfying in the case where it's suggested version is equivalent to the current version (except for the build number), where if that's the case, you do an extra check on the build number?

So something like:

// Say I've got the latest version installed
currentInstalledVersion="0.1.5+2"
// As you point out, maxSatisfying will return "0.1.5" which is the problem
var suggestedMax = maxSatisfying(currentInstalledVersion, '0.1.5+2', options)
// So let's do an extra check here
if (isEqual(currentInstalledVersion, suggestedMax ) { // ie. 0.1.5.2 == 0.1.5.2+2
  // Do an extra check on build numbers
  versions = compareBuild(currentInstalledVersion, suggestedMax);
  if (versions > 0) {
   // suggest suggestedMax
  } else {
  // suggest currentInstalledVersion
  }  
} else {
  // proceed as before
}

[ghost]

#827