marky-markdown icon indicating copy to clipboard operation
marky-markdown copied to clipboard

Process all image/link URLs during github rewrites

Open revin opened this issue 8 years ago • 2 comments

The github URL-rewriting markdown-it plugin was accidentally only doing a single URL replacement per html_block; this change recursively processes every occurrence instead.

Fixes #415.

revin avatar Oct 06 '17 21:10 revin

@revin 👋 I haven't had a chance to dig into this yet, but I'd be interested to see if we can replace the regex with //g and avoid the recursive step -- I bet we can figure something out.

bcoe avatar Oct 18 '17 18:10 bcoe

as an alternative, if we can't, we could switch the recursive step to a stack structure and at least eliminate the chance of a stack overflow.

bcoe avatar Oct 18 '17 18:10 bcoe