npgsql
Fix For issue #106
This should be full fix for test also. Both AlterColumnOperation, CreateTableOperation and AddColumnOpreation are consistent now, along with their tests.
Old pull request is closed by mistake, So I've created this one. Sorry.
I don't know what happened but this pull request modifications are again not present and issue #106 is still present in the latest release.
What shoud I do to commit it again?
@sparkybg I'm not sure I understand - are you not managing to push your local modifications to this PR on github?
I dont understand either - the modifications in this pull request are visible in the commits, for example here: https://github.com/npgsql/EntityFramework6.Npgsql/pull/163/commits/3bcdb98152f2f97e0b1d633b2b497381cee4a687
And here: https://github.com/npgsql/EntityFramework6.Npgsql/pull/163/commits/55bef3994515d0f18727aeeb1469fb0fb0b622b6
But they are not present in the current source code here: https://github.com/npgsql/EntityFramework6.Npgsql/blob/main/EF6.PG/NpgsqlMigrationSqlGenerator.cs
I don't know what happened. I deleted my local repository maybe a month ago, but they shoud have been pushed already long before this - the commits are nearly 1 year old.
Nothing is visible on the history also: https://github.com/npgsql/EntityFramework6.Npgsql/commits/main/EF6.PG/NpgsqlMigrationSqlGenerator.cs
@sparkybg this pull request was never merged, it's still open - this is why its changes aren't appearing in the main branch... Are you waiting for this to be reviewed and merged?
Well, should I do something in order for it to be merged? This is mandatory for code-first migrations when non-nullable columns are added to a table which already has data in it.
This would need to get reviewed and merged, given that this project is mostly archived there isn't much happening. @Emill are you interested in taking a look?