ShopifySharp icon indicating copy to clipboard operation
ShopifySharp copied to clipboard

RefundLineItem SubTotalTaxSet - copypaste issue?

Open nyan-cat opened this issue 1 year ago • 1 comments

RefundLineItem has this decimal property:

[JsonProperty("total_tax")]
public decimal? TotalTax { get; set; }

And PriceSet version of it:

[JsonProperty("total_tax_set")]
public PriceSet TotalTaxSet { get; set; }

All good so far. Also it has this decimal property:

[JsonProperty("subtotal")]
public decimal? SubTotal { get; set; }

And this PriceSet version:

[JsonProperty("subtotal_set")]
public PriceSet SubTotalTaxSet { get; set; }

JSON name is subtotal_set, but C# name is SubTotalTaxSet. Is that a typo? Shouldn't it be just SubTotalSet, which is not related to taxes?

nyan-cat avatar May 17 '24 10:05 nyan-cat

Hey, good catch! It does look like a copy/paste issue. I'll get this fixed!

nozzlegear avatar May 18 '24 21:05 nozzlegear