android-forensics icon indicating copy to clipboard operation
android-forensics copied to clipboard
verified publisher icon nowsecure

moved permissions before <application> tag

Open harikris opened this issue 11 years ago • 4 comments

testing forking and pull request process for aflogical ose repo

moved permissions before tag

harikris avatar Jul 21 '14 16:07 harikris

is the external storage functionality already integrated?

marcograss avatar Aug 05 '14 09:08 marcograss

we are just detecting the presence (or absence) of external storage at this point. we are not making use of the detection result. also, the ext sd card detection does not cover all the various permutations of /proc/mounts. so, some more conditions might have to be handled in src/com/viaforensics/android/os/GetRemovableDevice.java.

harikris avatar Aug 05 '14 14:08 harikris

ok, so it does not make sense to include it in a pull request for the opensource edition in master, if it's dead code (imo).

we can make another pull request for the external sdcard in master when the functionality is complete

marcograss avatar Aug 05 '14 14:08 marcograss

yeah. makes sense. we will revisit this when the viaProtect agent release is complete. meantime, feel free to cover missed cases in GetRemovableDevice.java i.e feel free to enhance it as u see fit Marco. It's a good idea to make that class as robust and comprehensive as possible. Currently, it works perfectly fine on a Samsung 5 unrooted device.

Regards,

  • vj

harikris avatar Aug 05 '14 14:08 harikris