websockify icon indicating copy to clipboard operation
websockify copied to clipboard

Allow graceful reloads in case of certificate changes

Open jackie-t opened this issue 7 years ago • 3 comments

I currently can't find a way to gracefully reload websockify in case the certificate changes.

With graceful I'd mean something similar to haproxy - when you reload haproxy, all existing connections are still served, but new ones receive the new certificate. At the moment, I restart websockify, which terminates any connections.

This would - I imagine - become more needed with let's encrypt, especially if they intend to shorten the certificate validity further.

If this is already possible, documentation would help in avoiding similar questions. ;)

jackie-t avatar Jan 14 '19 14:01 jackie-t

Unfortunately I don't think it is likely we'll support this as it is not supported by multiprocessing, which is the core architecture of the current code. :/

CendioOssman avatar Jan 18 '19 15:01 CendioOssman

Unfortunately I don't think it is likely we'll support this as it is not supported by multiprocessing, which is the core architecture of the current code. :/

Hello!

Apologies if I actually don't know well the codebase to understand if multiprocessing is something not related to this project. Does it exist an upstream bug about what you say?

Thank you.

valerio-bozzolan avatar Apr 08 '20 13:04 valerio-bozzolan

It's about the current architecture of websockify, so I don't think upstream Python needs to modify anything.

CendioOssman avatar Apr 09 '20 06:04 CendioOssman