websockify icon indicating copy to clipboard operation
websockify copied to clipboard

wrapped command not killed/closed in certain conditions

Open jd-jedi opened this issue 12 years ago • 0 comments

Hi guys,

Trying to use wrap option. Have socat proxying for actual vnc server.

./utils/websockify --timeout 20 --run-once --ssl-only 6900 -- socat... params.

I am expecting that when the websockify exits because of timeout, it closes/kills the socat as well. btw, it does work, if I press crt-c.

I guess, we should add do_cleanup() and use it to clean the self.cmd in some of these conditions. I tried putting it in, but it is getting called twice and dont know correct way of closing popen handle. May be has to do with multiprocess? (may need to spend more time on this). Would appreciate if some who understands the code can fix the issue/help fix it.

Thanks /Jd

jd-jedi avatar Apr 17 '14 13:04 jd-jedi