Quality parsing - Unknown source incorrectly labelled

[iskarian]

In core/searcher.py, in get_source, unknown sources are incorrectly labelled with the last source in the loop instead of the resolution. It looks like line 423,

src = 'Unknown-{}'.format(source, resolution)

should be

src = 'Unknown-{}'.format(resolution)

[nosmokingbandit]

Corrected in 99252dc.

It doesn't really affect anything since Unknown sources are completely ignored anyway, but its always good to have everything clean and neat.

[iskarian]

I found it while I was troubleshooting a separate issue where non-scene formatting on a tracker (and its files) made it so that Watcher was unable to identify the quality (e.g. BD 1080p instead of 1080p-BluRay). In library.py, starting line 558:

qual = titledata.pop('quality', None)
for source, aliases in core.CONFIG['Quality']['Aliases'].items():
    if any(a.lower() == qual.lower() for a in aliases):
        titledata['source'] = source
        break

throws an exception at qual.lower() when no quality was parsed.