client icon indicating copy to clipboard operation
client copied to clipboard
verified publisher icon nos

Find in page

Open mhuggins opened this issue 7 years ago • 3 comments

Describe the solution you'd like and the expected behavior

The user should be able to find text in the current page.

Is your feature request related to a problem? Please describe.

Users can't search for text in the page.

Possible implementation / References

  • https://github.com/electron/electron/blob/master/docs/api/web-contents.md#contentsfindinpagetext-options
  • https://github.com/electron/electron/blob/master/docs/api/web-contents.md#event-found-in-page

Additional context

N/A

mhuggins avatar Sep 27 '18 05:09 mhuggins

This needs design. /cc @fabric-8

mhuggins avatar Nov 20 '18 03:11 mhuggins

Find in Page Design Proposal

🕹 Click Prototype 🖼 Master Template (Overview)

kapture 2018-11-26 at 5 48 57

This proposal would add a "more" menu to the browser from where the user could reach the "find in page" (as well as downloads).

Happy to hear your thoughts on this!

fabric-8 avatar Nov 26 '18 04:11 fabric-8

Love this! @fabric-8

deanpress avatar Nov 26 '18 13:11 deanpress