Roy Sindre Norangshol
Roy Sindre Norangshol
We have some more code that is work in progress, need a few more changes so we can easily just depend on this as a module and override and make...
This is ready for being reviewed, this allowed us to reuse your code while replacing main() with our own http server setup using api signing etc.
@bboreham : `git diff -M -C master serversidelabels --summary` might be helpful? Probably because file is copied and main then modified to remove what is put inside aggate.go. This one...
@bboreham : > Would it be simpler just to add query parameters ?foo=bar as labels? Sadly this would include other query parameters we need to send to the service for...
Because extensions are used like this: ```java class JUnit5ServerTest { @RegisterExtension static ServerExtension extension = new ServerExtension(); @Test void serverIsRunning() { Assertions.assertTrue(extension.getServer().isRunning()); } } ``` See https://www.arhohuttunen.com/junit-5-migration/ for helpful introduction...
https://www.baeldung.com/junit-5-extensions has quick introduction as well, and mentions we can use a static field for providing arguments for the extension. **Ctrl+f** `we should annotate a static field with the @RegisterExtension...
@jhannes I do, I made an internal version in Kotlin: companion objects are basically static methods/fields. ```kotlin class TestDataSourceFactory { companion object { fun getDataSource(): DataSource = when (System.getenv("ALP_USE_TESTCONTAINERS")) {...
in junit5: ```kotlin class AktivitetskravRepositoryTest { companion object { @RegisterExtension @JvmStatic var dbContext = DbContextExtension(TestDataSourceFactory.getDataSource()) } @Test fun `should be able to store and fetch `() { } } ```
I thought I had personally signed this CLA under this umbrella, anyhow , updated to commit this under Cisco even if I did this outside working hours. https://github.com/cncf/gitdm/pull/506 has an...
Here is my thought on the security considerations: (I hope I get this correct): We already allow it to execute javascript from the iframe, which means it can already do...