vim icon indicating copy to clipboard operation
vim copied to clipboard

theme does not set `Terminal` highlight group

Open ntessore opened this issue 3 years ago • 3 comments

As far as I can tell, the theme does not set the Terminal highlight group, which for me means a :terminal window has default foreground and background colours.

I would expect something like this does the trick:

"+- Vim 8 Terminal Colors -+
if has('terminal')
  let g:terminal_ansi_colors = [...]
  call s:hi("Terminal", ...)
endif

Relevant part of :h terminal-size-color:

To use a different color the Terminal highlight group can be used, for example: hi Terminal ctermbg=lightgrey ctermfg=blue guibg=lightgrey guifg=blue

ntessore avatar Sep 21 '22 08:09 ntessore

I believe linking to Normal group should be good enough highlight! link Terminal Normal Before certain version Vim was doing this by default. But suddenly the terminal became black and white.

Freedzone avatar Oct 29 '22 07:10 Freedzone

Thank you for your patience! 🙏🏼 It‘s been a while since I had free time to focus more on Nord, and my open source projects in general, and invest time in this issue due to work-life balance.

I recently published the first “Northern Post — The state and roadmap of Nord“ announcement which includes all details about the plans and future of the Nord project, including the goal of catching up with the backlog. This issue is part of the backlog and therefore I want to triage and process it to get one step closer to a “clean state“. Read the announcement about reaching the “clean“ contribution triage state in Nord‘s discussions for more details about the goal.

Therefore it has been added to the backlog in the central and single-source-of-truth project board that is also described in more detail in the roadmap announcement.


@ntessore Thanks again for your contribution! @vds2212 submitted the pull request #337 that will has been added to the backlog for further processing.

svengreb avatar Jun 08 '23 10:06 svengreb

Thank for your nice message. Don't put too much pressing on yourself.

I'm glad to help. Let me know if I can do something for the project.

But I can also just be patient. It is something I can also do :-)

vds2212 avatar Jun 10 '23 00:06 vds2212