nvim-terminal.lua icon indicating copy to clipboard operation
nvim-terminal.lua copied to clipboard

More escape code support + some bug fixes

Open 0xAdk opened this issue 4 years ago • 0 comments

Commit Overview:

Allow colons as argument seperators

this one is pretty self explanatory it allows for colons (:) to be used in place of semicolons (;) in escape codes

Pass color table

this fixes a bug you mentioned in another PR where you forgot to pass in the color table given to attach_to_buffer to highlight_buffer

Make function highlight_from_attributes more readable

this was just so I could understand it better as I was implementing the next commit

Support for common attributes

this is the big one with the most changes. the way I went about this was replacing the previous way of setting the current text attribute which was just a string that cterm and gui were set to, with a table of [string] = boolean.

the string part is the attribute name and the boolean part is if that current attribute is active. I chose this because it seemed like the simplest way to easily be able to toggle an attribute.

when the table is required as a string the values that are true are picked out and concatenated into a list delimited by commas (,) for the syntax highlighting or into a list delimited by underscores (_) for the highlight group name generator

this should fix #8 but there isn't really a list and tbh I don't understand what blueyed was talking about so maybe this commit has nothing to do with #8 at all :?...

Escape codes being leaked

sets synmaxcol to 0 so it doesn't stop after column 3000

this one I spent a long time trying to figure out what wrong and only after finding 'synmaxcol' did I find your comment speculating about it :/

should fix #11

0xAdk avatar Aug 24 '21 22:08 0xAdk