aceeditor-bundle icon indicating copy to clipboard operation
aceeditor-bundle copied to clipboard

Stimulus

Open tito10047 opened this issue 1 year ago • 3 comments

Add support for stimulus and asset mapper. Everithing is detected and configured automaticaly. only import asset as is described in readme.

tito10047 avatar Apr 02 '24 19:04 tito10047

I dont know how to fix that failed test for php 8.1. There is composer dependencies only for dev enviroment and that package is used only for tests. Or maybe is this feature better release with new version of this package?

tito10047 avatar Apr 03 '24 15:04 tito10047

I dont know how to fix that failed test for php 8.1. There is composer dependencies only for dev enviroment and that package is used only for tests. Or maybe is this feature better release with new version of this package?

Hey, first of all, thank you so much for all the effort of improving this package DX! Would you mind going through the core concepts of those changes and leaving some comments that would let me understand why the code is implemented in a given way? It's been a while since I used ACE Editor last time, some things like the Worker for example are not that obvious for me anymore.

norberttech avatar Apr 03 '24 21:04 norberttech

Hey, first of all, thank you so much for all the effort of improving this package DX! Would you mind going through the core concepts of those changes and leaving some comments that would let me understand why the code is implemented in a given way? It's been a while since I used ACE Editor last time, some things like the Worker for example are not that obvious for me anymore.

Of course. I will do that

tito10047 avatar Apr 04 '24 06:04 tito10047

Hi @norberttech any plan to do something with this PR?

tito10047 avatar Dec 26 '24 18:12 tito10047

Hi @norberttech any plan to do something with this PR?

I would be happy to merge it but before it needs to pass all the tests and needs to be rebased against 5.x branch

norberttech avatar Dec 26 '24 20:12 norberttech

Im happy to see all test are passed :)

tito10047 avatar Dec 26 '24 20:12 tito10047