node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Missing 'rewrap' and 'keys' command

Open luca648 opened this issue 3 years ago • 1 comments

Hello guys,

First of all I would like to thank you for providing this nice package.

I am opening this ticket because while using it for a typescript project I noticed that the commands rewrap and keys were missing. I then tried to extend the commands set thanks to the commands parameter of the lib but I encountered the two following difficulties :

  • The builtin commands object do not seem to be exported making it uncomfortable for someone to extend it : I had to copy the file to my project.

  • The type of the parameter is Array<{ method: string, path: string, scheme: any }> while the main function seems to expect an object obliging me to cast for the build to pass.

    That'd be great If you could take a look.

Regards,

Luca

luca648 avatar Mar 22 '22 11:03 luca648

Hey @luca648 :) I understand the issues you're encountering; Do you mind PRing these changes, please?

aviadhahami avatar Nov 10 '22 17:11 aviadhahami