node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Change nodejs support

Open adam2k opened this issue 4 years ago • 3 comments

Add node support to travis and remove support for node 6 and 7.

adam2k avatar Nov 16 '21 15:11 adam2k

Codecov Report

Merging #191 (bf75654) into master (18597dd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18597dd...bf75654. Read the comment docs.

codecov[bot] avatar Nov 16 '21 15:11 codecov[bot]

@kr1sp1n this is related to #189. I'm attempting to remove istanbul and use nyc instead, but there isn't support for node versions older than 8 for nyc from what the tests are reporting in #189.

adam2k avatar Nov 17 '21 16:11 adam2k

@kr1sp1n anything we can help with to get some of these issues resolved? Is it possible to add others to this repo as code reviewers?

adam2k avatar Dec 06 '21 21:12 adam2k

Trying to get this in asap :)

aviadhahami avatar Nov 10 '22 17:11 aviadhahami

@adam2k --> Travis was removed + Upgraded node; closing

aviadhahami avatar May 11 '23 15:05 aviadhahami