node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Changed write method from PUT to POST

Open owenfarrell opened this issue 5 years ago • 1 comments

Per the Vault API, version 1 of the K/V engine supports both PUT and POST methods when creating/updating secrets. But version 2 of the K/V engine only support POST.

This change updates the method used to write data from PUT to POST in order to provide better continuity for the K/V secrets engine, as well as align with other engines (AWS, Azure, GCP, et. al.) that only support POSTs.

owenfarrell avatar May 04 '20 20:05 owenfarrell

Codecov Report

Merging #156 (71c65ba) into master (5d12381) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d12381...71c65ba. Read the comment docs.

codecov[bot] avatar May 04 '20 20:05 codecov[bot]

please resolve conflicts :)

aviadhahami avatar May 11 '23 15:05 aviadhahami

@aviadhahami

owenfarrell avatar May 11 '23 16:05 owenfarrell

Codecov Report

Merging #156 (07b79c3) into master (ab2857a) will not change coverage. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          141       141           
=========================================
  Hits           141       141           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar May 11 '23 16:05 codecov-commenter