undici icon indicating copy to clipboard operation
undici copied to clipboard

fix(types): responseHeaders typo in type

Open vickvu opened this issue 2 years ago • 2 comments

This relates to...

N/A

Rationale

The name of the field should be responseHeaders

Changes

Change the field name to responseHeaders

Features

N/A

Bug Fixes

N/A

Breaking Changes and Deprecations

N/A

Status

  • [x] I have read and agreed to the Developer's Certificate of Origin
  • [ ] Tested
  • [ ] Benchmarked (optional)
  • [ ] Documented
  • [ ] Review ready
  • [ ] In review
  • [ ] Merge ready

vickvu avatar Oct 07 '23 23:10 vickvu

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (4601498) 85.43%. Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
- Coverage   85.54%   85.43%   -0.12%     
==========================================
  Files          76       76              
  Lines        6858     6866       +8     
==========================================
- Hits         5867     5866       -1     
- Misses        991     1000       +9     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/core/connect.js 80.00% <100.00%> (-1.25%) :arrow_down:
lib/fetch/body.js 97.67% <100.00%> (-0.02%) :arrow_down:
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/index.js 85.20% <100.00%> (ø)
lib/pool.js 100.00% <100.00%> (ø)
lib/websocket/connection.js 89.15% <100.00%> (+0.13%) :arrow_up:
lib/websocket/frame.js 100.00% <100.00%> (ø)
lib/client.js 93.07% <92.30%> (-0.05%) :arrow_down:
lib/core/util.js 92.63% <85.71%> (-3.16%) :arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 08 '23 00:10 codecov-commenter

@vickvu Do you need help with this?

kibertoad avatar Oct 23 '23 06:10 kibertoad

Fixed by #3375

tsctx avatar Jun 26 '24 21:06 tsctx