undici icon indicating copy to clipboard operation
undici copied to clipboard

fix: transfer nullish coalescing assignment(??=) syntax(#2117)

Open quanru opened this issue 2 years ago • 3 comments

close #2117

quanru avatar May 12 '23 03:05 quanru

Can you add a test? These shouldn't be exported in node 14.

KhafraDev avatar May 12 '23 06:05 KhafraDev

Node 14 is EOL. We have dropped support.

I found engines described in package.json is ">= 14": https://github.com/nodejs/undici/blob/9d30456aa6f195b83ea4ba36ed0b51a951e6bd87/package.json#L107

I got it #2119.

quanru avatar May 12 '23 06:05 quanru

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.26 :warning:

Comparison is base (9d30456) 85.86% compared to head (eb3a810) 85.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   85.86%   85.61%   -0.26%     
==========================================
  Files          76       75       -1     
  Lines        6610     6609       -1     
==========================================
- Hits         5676     5658      -18     
- Misses        934      951      +17     
Impacted Files Coverage Δ
lib/cookies/parse.js 90.90% <100.00%> (ø)
lib/fetch/headers.js 97.50% <100.00%> (ø)
lib/websocket/receiver.js 84.51% <100.00%> (ø)

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar May 12 '23 19:05 codecov-commenter

@ronag We can close this as engines in package.json is now set to >= 18.

Uzlopak avatar Jan 29 '24 07:01 Uzlopak