release-cloudflare-worker icon indicating copy to clipboard operation
release-cloudflare-worker copied to clipboard

Serve /docs from Worker

Open MattIPv4 opened this issue 11 months ago • 6 comments

During the investigation of https://github.com/nodejs/node/issues/57252 it was discovered that /docs is not currently served by the Cloudflare Worker, it is still served by the NGINX origin. This should probably be changed to be served by the Worker, unless there are factors I'm unaware of that mean it needs to be NGINX-served still -- both /api and /dist/latest/docs are served from the Worker.

MattIPv4 avatar Mar 01 '25 19:03 MattIPv4

@flakey5 @targos I believe we can do it asap, right?

ovflowd avatar Apr 05 '25 18:04 ovflowd

I can do it but does anyone remember why it wasn't done with the rest?

targos avatar Apr 06 '25 08:04 targos

I can do it but does anyone remember why it wasn't done with the rest?

I don't remember why, last time I remember before this the worker was serving /docs/ so :shrug:

flakey5 avatar Apr 21 '25 19:04 flakey5

Comparing https://nodejs.org/docs/ and https://r2.nodejs.org/docs/, the list of folders is not exactly the same. Some differences:

  • r2 links to npm/ and patch/ which don't exist
  • r2 does not link to existing directories such as v0.0.1

targos avatar Apr 30 '25 15:04 targos

Do we have any update here? @flakey5 apparently these folders mentioned above don't exist on r2? Is something missing here yet? 🤔

ovflowd avatar May 25 '25 13:05 ovflowd

This will be fixed along with #159, also once this is done I think it'd be good for us to cleanup the worker routes we have as well 😅

Image

flakey5 avatar Nov 02 '25 03:11 flakey5