fix(fetch): fixup generators and add error handling
This PR:
- Fixes the nasty fetch failed issue on deployments by rewriting the fetch statements to
.then().catch()format - Adds a missing type file
- Moves a constant to the constants file
- Simplifies an object creation
The latest updates on your projects. Learn more about Vercel for GitHub.
| Project | Deployment | Review | Updated (UTC) |
|---|---|---|---|
| nodejs-org | Preview | Dec 18, 2025 2:12pm |
👋 Codeowner Review Request
The following codeowners have been identified for the changed files:
Team reviewers: @nodejs/nodejs-website
Please review the changes when you have a chance. Thank you! 🙏
Codecov Report
:x: Patch coverage is 76.00000% with 12 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 73.65%. Comparing base (43ffe41) to head (b680586).
:warning: Report is 31 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| apps/site/util/fetch.ts | 64.70% | 12 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #8395 +/- ##
==========================================
- Coverage 76.40% 73.65% -2.75%
==========================================
Files 118 108 -10
Lines 9928 9193 -735
Branches 334 312 -22
==========================================
- Hits 7585 6771 -814
- Misses 2341 2420 +79
Partials 2 2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
📦 Build Size Comparison
Summary
| Metric | Value |
|---|---|
| Old Total Size | 4.34 MB |
| New Total Size | 4.34 MB |
| Delta | 0 B (0.00%) |
Changes
➕ Added Assets (1)
| Name | Size |
|---|---|
.next/static/chunks/4d75ead2ba2e5654.js |
204.26 KB |
➖ Removed Assets (1)
| Name | Size |
|---|---|
.next/static/chunks/1ebd0f9d6844fabb.js |
204.26 KB |
@nodejs/nodejs-website PTAL
Fetch is still timing out occasionally :-/
https://vercel.com/openjs/nodejs-org/EeD4bMYCN1DPW8Zj3BEaNmq3wv1N
Bump @avivkeller
Sorry for the delay! This must've slipped in between the cracks. I'll get this up to speed tomorrow!