nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Get Code Coverage >= 90%

Open avivkeller opened this issue 9 months ago • 4 comments

(Follow-up #7623)

After completing the migration to Codecov, our code coverage will be approximately 74.53%. I recommend the following action steps:

  • [ ] Set a minimum enforcement threshold of 70% coverage (See https://docs.codecov.com/docs/codecov-yaml)
  • [ ] Work towards increasing overall code coverage to 95% or higher
  • [ ] Once achieved, enforce a minimum of 90% coverage

avivkeller avatar Apr 17 '25 14:04 avivkeller

Should I take on this?

ShubhamOulkar avatar Jul 22 '25 05:07 ShubhamOulkar

You can work on it

AugustinMauroy avatar Jul 22 '25 06:07 AugustinMauroy

  • Set a minimum enforcement threshold of 70% coverage

Hi @avivkeller, I am little confused with threshold and target. Do you mean target 70%? Because threshold works differently in codecov threshold

My changes are going to be as follows,

coverage:
  status:
    patch:
      default:
        target: 70%
        threshold: 1%

comment:
  behavior: default
  require_changes: true

ShubhamOulkar avatar Jul 24 '25 13:07 ShubhamOulkar

Yes, I mean project "target", sorry

avivkeller avatar Jul 24 '25 13:07 avivkeller