nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

List WinGet as install method for Windows

Open cinderblock opened this issue 1 year ago • 8 comments

Description

This change adds winget to the list of ways to install Node.js on Windows.

Validation

A new entry on https://nodejs.org/en/download/package-manager

Related Issues

#4028 - regression #3993

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [ ] I have run npm run format to ensure the code follows the style guide.
  • [ ] I have run npm run test to check if all tests are passing.
  • [ ] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

npm install fails on my Windows machine. Cannot run any test commands.

cinderblock avatar Jul 31 '24 00:07 cinderblock

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 31, 2024 6:14pm

vercel[bot] avatar Jul 31 '24 00:07 vercel[bot]

Sorry, I don't think this will land; For context, we're halting any additions or changes to the CodeBoxes as we redesign the Package Managers page, splitting it into a Node version managers page and an OS package manager page.

I don't speak for the website team, but I don't think this would land, at least now, since we are still in a scoping phase of how we will restructure this page.

I appreciate the effort you've put in here. I'll let other website team members also comment on this :)

ovflowd avatar Jul 31 '24 11:07 ovflowd

@ovflowd That makes sense. Thank you for the detail.

I hope WinGet gets noted more prominently. It's the easiest and fastest way to install Node on modern Windows systems. No extra dependencies and is easy to update everything: winget upgrade --all

cinderblock avatar Jul 31 '24 18:07 cinderblock

@ovflowd That makes sense. Thank you for the detail.

I hope WinGet gets noted more prominently. It's the easiest and fastest way to install Node on modern Windows systems. No extra dependencies and is easy to update everything: winget upgrade --all

Winget is already listed here: https://nodejs.org/en/download/package-manager/all#windows-1

ovflowd avatar Jul 31 '24 20:07 ovflowd

I saw that in the source code but wasn't sure how to even get to the ./all url from the normal page.

In any case, glad y'all are on it!

cinderblock avatar Aug 01 '24 05:08 cinderblock

Friendly bump. Any progress on the Package Managers page updates? Is there a milestone/branch we can track?

cinderblock avatar Sep 09 '24 23:09 cinderblock

Friendly bump. Any progress on the Package Managers page updates? Is there a milestone/branch we can track?

Hey there! Unfortunately not. I realized I forgot to open the issue here, I was low bandwidth and asked for colleagues to open one (https://openjs-foundation.slack.com/archives/C044DNU6TEH/p1724524239630829)

Let me open an issue to keep track of the work :)

ovflowd avatar Sep 10 '24 07:09 ovflowd

I've opened an issue: https://github.com/nodejs/nodejs.org/issues/7037, finally!

ovflowd avatar Sep 12 '24 13:09 ovflowd

~Hey @cinderblock since the recent changes on our Downloads page we can revisit this! I've noticed that Winget is quite outdated and doesn't contain any versions of the latest major v20,v21,v22 and v23 versions.~

~cc @nodejs/platform-windows and @nodejs/build any idea who maintains that Winget package? I see a OpenJS namespace here? https://winget.run/pkg/OpenJS/NodeJS~

Edit: It is frequently updated. @cinderblock feel free to make a new PR. I'm going to add guidelines on how to add new methods.

ovflowd avatar Dec 28 '24 13:12 ovflowd

When a new node version is released, is it instantly available on winget, or does it require a followup action (automated or manual) to make it available?

ljharb avatar Dec 28 '24 18:12 ljharb

When a new node version is released, is it instantly available on winget, or does it require a followup action (automated or manual) to make it available?

No idea, haven't checked to be honest.

ovflowd avatar Dec 28 '24 18:12 ovflowd

i am not well versed in winget from a maintainer pov, only from a user pov, but afaik new versions are added via PR that require manual review, the PR can be done manually or automatically:

  • tool from microsoft to automate creating winget manifests: https://github.com/microsoft/winget-create
  • winget package readme: https://github.com/microsoft/winget-pkgs/blob/master/doc/README.md

masterflitzer avatar Dec 28 '24 18:12 masterflitzer

gotcha, then it seems winget might make sense as a "community" option?

ljharb avatar Dec 28 '24 18:12 ljharb

You can also look at how PowerToys automated publishing to the WinGet Community repository at: https://github.com/microsoft/PowerToys/blob/main/.github/workflows/package-submissions.yml

denelon avatar Jan 06 '25 18:01 denelon

You can also look at how PowerToys automated publishing to the WinGet Community repository at: microsoft/PowerToys@main/.github/workflows/package-submissions.yml

Created a PR that proposes automating the release as they're published at GitHub

  • https://github.com/nodejs/node/pull/56774

mdanish-kh avatar Jan 26 '25 17:01 mdanish-kh

I feel this PR has been abandoned by the author and would recommend a new one to be opened.

ovflowd avatar Jan 26 '25 21:01 ovflowd

Are all of the changes to the download page finished? I'm happy to rebase/redo these changes, if necessary.

Are we waiting for #56774 to land?

cinderblock avatar Jan 27 '25 09:01 cinderblock