nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore: remove reference to outdated examples

Open avivkeller opened this issue 1 year ago • 5 comments

Description

This PR removes the reference to the outdated example repository, as in its current state, it may confuse users more than help them.

Related Issues

https://github.com/nodejs/admin/issues/883 discusses archiving the repository, and this is the only actively maintained link to the repository.

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [ ] I have run npm run format to ensure the code follows the style guide.
  • [ ] I have run npm run test to check if all tests are passing.
  • [ ] I have run npx turbo build to check if the website builds without errors.

avivkeller avatar Jun 19 '24 22:06 avivkeller

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 5, 2024 5:57pm

vercel[bot] avatar Jun 19 '24 22:06 vercel[bot]

https://nodejs-org-git-fork-redyetidev-patch-1-openjs.vercel.app/en/learn/getting-started/introduction-to-nodejs

avivkeller avatar Jun 19 '24 22:06 avivkeller

blocking until https://github.com/nodejs/admin/issues/883 is resolved

Thanks! I wanted this blocked until that's resolved anyway, but I wanted to put it in the works to make sure it's okay dev-wise

avivkeller avatar Jun 20 '24 15:06 avivkeller

This PR will need to be rebased or recreated now that https://github.com/nodejs/nodejs.org/pull/6850 merged.

bmuenzenmeyer avatar Jul 05 '24 11:07 bmuenzenmeyer

Done!

avivkeller avatar Jul 05 '24 17:07 avivkeller

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.243s :stopwatch:

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]