nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Add translations of snippet comments from Download Package Manager boxes

Open ovflowd opened this issue 1 year ago • 4 comments

The snippets below are defined on a TypeScript file and shown below:

image

We can call the translation service (t) and include translation strings within the i18n JSON files for such comments; otherwise, it feels like the translation is lacking here.

ovflowd avatar Jun 19 '24 14:06 ovflowd

Hey, can I work on this issue?
Could you explain the issue and the approach?

PalashChitnavis avatar Jun 27 '24 01:06 PalashChitnavis

Thanks for your interest. We don't assign tickets if we can help it. Feel free to submit a pull request if you have time. Reference 🍪 https://www.redhat.com/en/blog/dont-lick-cookie

bmuenzenmeyer avatar Jun 27 '24 02:06 bmuenzenmeyer

@bmuenzenmeyer Hello, they weren't asking to be assigned an outcome, they were asking for guidance 😁.

So @PalashChitnavis, in util/getNodeDownloadSnippet.ts you have a function that return string to put on codebox. So issue "ask" to add i18n for comment. To add i18n on a string you I'll need to use client hooks from next-intl call useTranslation.

Also we have this doc about how to contribute on this repo : COLLABORATOR_GUIDE.md

AugustinMauroy avatar Jun 27 '24 07:06 AugustinMauroy

To be fair, they did both. On mobile i answered too quickly, thanks for giving them next steps!

bmuenzenmeyer avatar Jun 27 '24 13:06 bmuenzenmeyer

Hey @PalashChitnavis , Could you please let me know if you are working on this? else I will look into it. Thanks

nilkhankari avatar Jul 07 '24 07:07 nilkhankari

@nilkhankari I think you can go head

AugustinMauroy avatar Jul 07 '24 08:07 AugustinMauroy