nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard
verified publisher icon nodejs

Footer missing on Learn layout

Open bmuenzenmeyer opened this issue 1 year ago • 4 comments

https://nodejs.org/en/learn/getting-started/introduction-to-nodejs

Screenshot_20240610_181426_Chrome.jpg

bmuenzenmeyer avatar Jun 10 '24 23:06 bmuenzenmeyer

Same on About too https://nodejs.org/en/about

mikeesto avatar Jun 11 '24 03:06 mikeesto

footer missing in 'About and 'Learn" layout , already on it,raising PR

Wellitsabhi avatar Jun 11 '24 06:06 Wellitsabhi

Id say these pages are following the figmas, which have no footer. Now, not sure if we should add or not :shrug:

Im fine eitherways.

ovflowd avatar Jun 17 '24 11:06 ovflowd

I noticed that too but it looks REALLY out of place to me to selectively render a global component. I am surprised it didn't come up earlier, TBH.

bmuenzenmeyer avatar Jun 17 '24 14:06 bmuenzenmeyer

@bmuenzenmeyer raised pr for this issue https://github.com/nodejs/nodejs.org/pull/6949. can you review the PR.

rakeshkumar1019 avatar Jul 31 '24 07:07 rakeshkumar1019

Can you please assign this project or if it is assigned for someone please give me another issue I am new to open source is there any advice or roadmap that is appreciatable

velu-murugesan avatar Aug 28 '24 02:08 velu-murugesan