nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: correct headings levels for Previous Releases page

Open theoludwig opened this issue 1 year ago • 3 comments

Description

As mentioned in https://github.com/nodejs/nodejs.org/pull/6676#issuecomment-2084837883

On the "Previous Releases" page, the headings levels were wrong: h1 -> h3.

Validation

The headings levels should now be correct: h1 -> h2.

image

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run format to ensure the code follows the style guide.
  • [x] I have run npm run test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.

theoludwig avatar Apr 30 '24 18:04 theoludwig

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 30, 2024 6:07pm

vercel[bot] avatar Apr 30 '24 18:04 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 100 🟢 92 🔗

github-actions[bot] avatar Apr 30 '24 22:04 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 5.774s :stopwatch:

github-actions[bot] avatar Apr 30 '24 22:04 github-actions[bot]