nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: Made RouterSelect inline (#6560)

Open kujo205 opened this issue 1 year ago • 3 comments

Description

I changed odd behavior of RouterSelect, now items are under the select upd: I also removed translations from labels as labels weren't needed in the design

Validation

Here how it looks: image

Related Issues

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

kujo205 avatar Mar 27 '24 09:03 kujo205

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 6, 2024 9:51am

vercel[bot] avatar Mar 27 '24 09:03 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 96 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 96 🟠 82 🔗
/en/blog 🟢 98 🟢 90 🟢 96 🟢 92 🔗

github-actions[bot] avatar Mar 28 '24 07:03 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 83%
79.33% (453/571) 75.93% (142/187) 69.91% (79/113)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 :zzz: 0 :x: 0 :fire: 4.476s :stopwatch:

github-actions[bot] avatar Mar 28 '24 07:03 github-actions[bot]

This is good to be merged as it is.

ovflowd avatar Apr 02 '24 09:04 ovflowd

@canerakdas hey, how do I pass UI Review and UI Tests checks? 😙

kujo205 avatar Apr 06 '24 16:04 kujo205