nodejs.org
nodejs.org copied to clipboard
fix: Made RouterSelect inline (#6560)
Description
I changed odd behavior of RouterSelect, now items are under the select upd: I also removed translations from labels as labels weren't needed in the design
Validation
Here how it looks:
Related Issues
Check List
- [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
- [x] I have run
npx turbo formatto ensure the code follows the style guide. - [x] I have run
npx turbo testto check if all tests are passing. - [x] I have run
npx turbo buildto check if the website builds without errors. - [x] I've covered new added functionality with unit tests if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| nodejs-org | ✅ Ready (Inspect) | Visit Preview | Apr 6, 2024 9:51am |
Lighthouse Results
| URL | Performance | Accessibility | Best Practices | SEO | Report |
|---|---|---|---|---|---|
| /en | 🟢 94 | 🟢 90 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about | 🟢 99 | 🟢 91 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about/previous-releases | 🟢 96 | 🟢 90 | 🟢 100 | 🟢 92 | 🔗 |
| /en/download | 🟢 100 | 🟠 89 | 🟢 96 | 🟠 82 | 🔗 |
| /en/blog | 🟢 98 | 🟢 90 | 🟢 96 | 🟢 92 | 🔗 |
Unit Test Coverage Report
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 79.33% (453/571) | 75.93% (142/187) | 69.91% (79/113) |
Unit Test Report
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 90 | 0 :zzz: | 0 :x: | 0 :fire: | 4.476s :stopwatch: |
This is good to be merged as it is.
@canerakdas hey, how do I pass UI Review and UI Tests checks? 😙