nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: layout shift on blogs due to i18n comps

Open Kinfe123 opened this issue 1 year ago • 9 comments

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

Kinfe123 avatar Mar 24 '24 09:03 Kinfe123

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 24, 2024 9:04am

vercel[bot] avatar Mar 24 '24 09:03 vercel[bot]

Could you give more information about this change. Because now it's just change the render of blog page. too keep footer visible.

AugustinMauroy avatar Mar 24 '24 09:03 AugustinMauroy

I don't understand what the issue is. Could you attach a screenshot, reproduction steps or a video?

ovflowd avatar Mar 24 '24 12:03 ovflowd

sorrry for not being in touch

Kinfe123 avatar Mar 24 '24 18:03 Kinfe123

@Kinfe123 which browser do you use? 'cause I can't reproduce your behaviour on safari or Chrome.

Also you solution change the design of page. I mean NavBar and Footer become sticky

AugustinMauroy avatar Mar 24 '24 20:03 AugustinMauroy

yeah i thought that would be a good thing ...making a sticky for the constant page layouts

Kinfe123 avatar Mar 28 '24 14:03 Kinfe123

lemme reproduce if i can

Kinfe123 avatar Mar 28 '24 14:03 Kinfe123

Any luck reproducing the issue?

ovflowd avatar Mar 28 '24 23:03 ovflowd

Closing for now, if the author still wishes to proceed with the PR, feel free to reopen.

ovflowd avatar Apr 15 '24 08:04 ovflowd