Fixed Issue Select ARM 64 by Default

Open rhlshah opened this issue 1 year ago • 3 comments

Description

Selected ARM64 by default in the dropdown if user is visiting from M1

Added "getArchitecture" utility and embed it on our util that detects the UserOS.
Checked if architecture is ARM if visiting from M1

Validation

Related Issues

Fixes #6364

Mar 04 '24 20:03 rhlshah

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Mar 6, 2024 11:14am

Mar 04 '24 20:03 vercel[bot]

@trivikr Could you please review my PR?

Mar 04 '24 20:03 rhlshah

Could you please review my PR?

I'm not a maintainer of Node.js website, and had created issue while playing with the new redesign. The PR has notified @nodejs/nodejs-website, they'll be reviewing your code.

Mar 04 '24 20:03 trivikr

I have made the changes and have also added the tests. Pleas have a look.

Mar 06 '24 00:03 rhlshah

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 100	🟢 96	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 96	🟢 100	🟢 92	🔗
/en/about/previous-releases	🟢 100	🟢 95	🟢 100	🟢 92	🔗
/en/download	🟢 100	🟢 95	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 96	🟢 100	🟢 92	🔗

Mar 06 '24 11:03 github-actions[bot]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	80.54% (447/555)	79.55% (144/181)	73.14% (79/108)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
90	0 :zzz:	0 :x:	0 :fire:	4.429s :stopwatch:

Mar 06 '24 11:03 github-actions[bot]