nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

New webpage Read Streams example is confusing

Open yoavain opened this issue 1 year ago • 2 comments

Enter your suggestions in details:

Lines 3-4 of the "Read Streams" example are confusing. I suggest extracting them into a new "Fetch" example.

image

yoavain avatar Mar 02 '24 08:03 yoavain

I see! That's indeed confusing because the Read Streams shows two different examples.

Feel free to make a PR removing the first fetch part, but if possible, find a way to make the example still last 11 lines. (We're aiming for every example to be 11 lines to keep the CodeBox consistent)

ovflowd avatar Mar 02 '24 10:03 ovflowd

agree on this - mentioned when first introduced too https://github.com/nodejs/nodejs.org/pull/6215#pullrequestreview-1814550649

bmuenzenmeyer avatar Mar 03 '24 05:03 bmuenzenmeyer

closed via https://github.com/nodejs/nodejs.org/pull/6457

bmuenzenmeyer avatar Mar 08 '24 03:03 bmuenzenmeyer