nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix(i18n): fix typo in translation keys

Open EmirBoyaci opened this issue 2 years ago • 10 comments

Two i18n keys that includes typo changed

Fixes #5091

EmirBoyaci avatar Mar 09 '23 13:03 EmirBoyaci

LGTM! Thank you for your contribution 😄

Always! But, do you have any idea why PR checks didn't start? I am asking this because I think you're maintainer, so it should be started.. Isn't it?

EmirBoyaci avatar Mar 10 '23 12:03 EmirBoyaci

Always! But, do you have any idea why PR checks didn't start? I am asking this because I think you're maintainer, so it should be started.. Isn't it?

Yeah, sounds like a weird bug. GitHub is not giving me any option to start them 😅

I wonder why. Let me see if I can force trigger them.

ovflowd avatar Mar 10 '23 12:03 ovflowd

Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits.

ovflowd avatar Mar 10 '23 12:03 ovflowd

Hmm, it's not allowing me. Could you re-push the changes? I see that the commit is not verified and we kinda require signed commits.

Sure but signed commit requirement is not included in Contributing Guide. IMHO you should also include it..

EmirBoyaci avatar Mar 10 '23 12:03 EmirBoyaci

Correct, let me update that.

ovflowd avatar Mar 10 '23 12:03 ovflowd

@ovflowd could you please check it again? I force pushed signed commit :)

EmirBoyaci avatar Mar 10 '23 12:03 EmirBoyaci

I was looking for why it is stuck on "Expected — Waiting for status to be reported" stage and found one solution. Unfortunately, the solution did not work. Second force-push was for this trial.

EmirBoyaci avatar Mar 10 '23 12:03 EmirBoyaci

Ok next solution did not work also. I will not do anything after now XD

EmirBoyaci avatar Mar 10 '23 12:03 EmirBoyaci

Ok next solution did not work also. I will not do anything after now XD

Now it worked!

ovflowd avatar Mar 10 '23 12:03 ovflowd

Ok next solution did not work also. I will not do anything after now XD

Now it worked!

Yea, we got 🟢 also! 🚀

EmirBoyaci avatar Mar 10 '23 13:03 EmirBoyaci