nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard
verified publisher icon nodejs

Update CodeQL workflow

Open XhmikosR opened this issue 3 years ago • 6 comments

  • update to the latest action tags
  • specify security-and-quality and category

XhmikosR avatar Nov 12 '22 07:11 XhmikosR

A quick fix for the code's safe problem, hope it helps. Any suggestion would be appreciated.

SEWeiTung avatar Nov 12 '22 10:11 SEWeiTung

@XhmikosR：Maybe you can fix the conflict. @nodejs/nodejs-dev : Any one would be kind to review XhmikosR's submit, as well as mine at https://github.com/nodejs/nodejs.org/pull/4931

SEWeiTung avatar Nov 17 '22 07:11 SEWeiTung

I'd wait for #4931 after this PR has landed.

XhmikosR avatar Nov 17 '22 14:11 XhmikosR

Sorry for the delay, I didn't notice this existed. #4931 got merged. Feel free to rebase.

ovflowd avatar Dec 30 '22 11:12 ovflowd

@XhmikosR & @ovflowd:Finally got finished! Too tired to change the code totally without using "fs.existsSync(....)" to meet the safety of the codeQL

XD

SEWeiTung avatar Jan 13 '23 11:01 SEWeiTung

Hey @MaledongGit any updates here?

ovflowd avatar Feb 27 '23 14:02 ovflowd

Closing as we're using the built-in CodeQL workflow now.

ovflowd avatar Mar 14 '23 10:03 ovflowd