nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

i18n(ja): Added Japanese pages

Open e-jigsaw opened this issue 3 years ago • 2 comments

Description

Added Japanese locale file.

Related Issues

https://github.com/nodejs/nodejs.dev/issues/2612#issuecomment-1242806267

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • [x] I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • [x] I have checked that the build works locally and that npm run build work fine.
  • [x] I've covered new added functionality with unit tests if necessary.

e-jigsaw avatar Sep 14 '22 01:09 e-jigsaw

@nodejs/nodejs-ja review please!

e-jigsaw avatar Sep 14 '22 01:09 e-jigsaw

Codecov Report

Base: 66.02% // Head: 66.95% // Increases project coverage by +0.92% :tada:

Coverage data is based on head (4604f73) compared to base (fd57b87). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2764      +/-   ##
==========================================
+ Coverage   66.02%   66.95%   +0.92%     
==========================================
  Files         118      143      +25     
  Lines        1351     1622     +271     
  Branches      342      384      +42     
==========================================
+ Hits          892     1086     +194     
- Misses        422      493      +71     
- Partials       37       43       +6     
Impacted Files Coverage Δ
src/templates/blog.tsx 0.00% <0.00%> (-100.00%) :arrow_down:
util-node/getNodeReleasesData.js 91.30% <0.00%> (-6.32%) :arrow_down:
src/__fixtures__/page.tsx 94.11% <0.00%> (-5.89%) :arrow_down:
src/pages/index.tsx 100.00% <0.00%> (ø)
src/templates/api.tsx 0.00% <0.00%> (ø)
src/templates/learn.tsx 100.00% <0.00%> (ø)
util-node/createSlug.js 100.00% <0.00%> (ø)
util-node/getNvmData.js 100.00% <0.00%> (ø)
src/hooks/useOnScreen.tsx 100.00% <0.00%> (ø)
src/pages/about/index.tsx 100.00% <0.00%> (ø)
... and 180 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 14 '22 01:09 codecov-commenter

@e-jigsaw I think we can proceed with this PR, as you seem to be the only active JP translator.

ovflowd avatar Oct 09 '22 14:10 ovflowd

Please find a preview at: https://staging.nodejs.dev/2764/

github-actions[bot] avatar Oct 23 '22 00:10 github-actions[bot]

今さらこれに気づきました。ちょっと確認させてください。

okuryu avatar Oct 23 '22 04:10 okuryu

@e-jigsaw, the CI seems to be failing. Could you run yarn jest -u?

ovflowd avatar Oct 25 '22 07:10 ovflowd

Sorry, I accidentally clicked to close the PR 🤦

ovflowd avatar Oct 25 '22 07:10 ovflowd

@ovflowd fixed :)

e-jigsaw avatar Oct 28 '22 01:10 e-jigsaw

Hey @e-jigsaw I noticed that the ja.json file is outdated (based on the translation keys from en.json)

Could you compare the missing entries from en.json and remove the deprecated ones from ja.json?

Thank you so much! (After this I think we will only need one last review, and we'll be ready to merge)

ovflowd avatar Nov 03 '22 10:11 ovflowd

@ovflowd Hi updated json

e-jigsaw avatar Nov 05 '22 05:11 e-jigsaw

@AugustinMauroy Thanks for reviewing! I referred a lot your work.

@ovflowd I think this is ready to merge. Is there something I'm missing?

e-jigsaw avatar Nov 10 '22 14:11 e-jigsaw

@ovflowd I think this is ready to merge. Is there something I'm missing?

Let's just have a final pass/review from @nodejs/nodejs-ja and then I think we're good to proceed!

ovflowd avatar Nov 10 '22 14:11 ovflowd

@okuryu @watilde もう一度レビューいただけるとたすかります....!! 🙏 🙏

e-jigsaw avatar Nov 10 '22 16:11 e-jigsaw

@ovflowd good to go!

e-jigsaw avatar Nov 11 '22 00:11 e-jigsaw