nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Update node-javascript-language.en.md

Open adrianghub opened this issue 3 years ago • 2 comments

  • update link references

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [ ] I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • [ ] I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • [ ] I have checked that the build works locally and that npm run build work fine.
  • [ ] I've covered new added functionality with unit tests if necessary.

Description

Related Issues

adrianghub avatar Aug 19 '22 06:08 adrianghub

Codecov Report

Merging #2655 (4a287a8) into main (bf234b7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2655   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files         103      103           
  Lines        1113     1113           
  Branches      310      310           
=======================================
  Hits          929      929           
  Misses        178      178           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 19 '22 06:08 codecov-commenter

We are fixing these links as on this issue https://github.com/nodejs/nodejs.dev/issues/2647

Any reason why suggesting the MDN links exclusively? 👀

ovflowd avatar Aug 19 '22 07:08 ovflowd

As no one approved this PR and we had objections, I'm closing this PR.

ovflowd avatar Oct 09 '22 14:10 ovflowd