nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Added use of types in node - issue#2149

Open shikhar13012001 opened this issue 4 years ago • 7 comments

Description

Added brief description and example on how to add node types when using node js with typeScript.

Related Issues

Fixes issue #2149

shikhar13012001 avatar Jan 21 '22 21:01 shikhar13012001

Codecov Report

Merging #2218 (0261a9f) into main (a398b5a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2218   +/-   ##
=======================================
  Coverage   91.29%   91.29%           
=======================================
  Files          84       84           
  Lines         919      919           
  Branches      251      251           
=======================================
  Hits          839      839           
  Misses         79       79           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a398b5a...0261a9f. Read the comment docs.

codecov-commenter avatar Jan 21 '22 22:01 codecov-commenter

I could be misunderstanding https://github.com/nodejs/nodejs.dev/issues/2149 but I think the suggestion there was to show how to install & type built-in node modules (e.g. https/stream) rather than a third party package such as Express

mikeesto avatar Jan 22 '22 00:01 mikeesto

I could be misunderstanding #2149 but I think the suggestion there was to show how to install & type built-in node modules (e.g. https/stream) rather than a third party package such as Express

@mikeesto Thankyou for suggesting changes, that was really helpful , actually I wasn't sure when issue mentioned how to install Node Types so I added general example of third party package as express. I will try to improve the PR with requested changes

shikhar13012001 avatar Jan 22 '22 06:01 shikhar13012001

Please find a preview at: https://staging.nodejs.dev/2218/

github-actions[bot] avatar Jan 26 '22 08:01 github-actions[bot]

Thankyou for assessment @santimirandarp :)

shikhar13012001 avatar Jan 26 '22 11:01 shikhar13012001

Please find a preview at: https://staging.nodejs.dev/2218/

github-actions[bot] avatar Jan 28 '22 17:01 github-actions[bot]

This pull request is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 03 '22 02:08 github-actions[bot]

This pull request was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Aug 18 '22 02:08 github-actions[bot]