nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Ensure there are no abandoned or broken links from nodejs.org => nodejs.dev

Open joesepi opened this issue 4 years ago • 3 comments

This should be a guiding principle in all work being done here.

joesepi avatar Jun 09 '21 18:06 joesepi

I'll give this a try!

banchecky avatar Jun 09 '21 23:06 banchecky

Great @chanbecky!! Thanks for looking at this.

joesepi avatar Jun 10 '21 16:06 joesepi

@bnb suggested us to use Linkinator: https://github.com/JustinBeckwith/linkinator

ovflowd avatar Sep 10 '22 21:09 ovflowd

Hey! I would like to take up this issue. From what I can understand, this involves checking all links in the newly built nodejs.dev website & ensure that there are no broken links?

BabyElias avatar Oct 03 '22 13:10 BabyElias

From what I can understand, this involves checking all links in the newly built nodejs.dev website & ensure that there are no broken links?

We need to compare that all links within nodejs.org can be accessible here. Opening a page on nodejs.org and replacing the .org to .dev should either land on a respective page or redirect to somewhere.

Blog posts are the biggest factor, for now, as we haven't migrated blog posts to nodejs.dev, so ideally, this should be done after that. But if you ignore all the blog posts for now, you could test this for now.

ovflowd avatar Oct 03 '22 13:10 ovflowd

Understood ! Will begin working on the same.

BabyElias avatar Oct 03 '22 13:10 BabyElias

Found a Broken Link image image image

The same Blocking vs Non-Blocking hyperlink present on the dev website, instead points to the Introduction to Node.js page. image

BabyElias avatar Oct 04 '22 05:10 BabyElias

Same goes for this link :https://nodejs.org/en/docs/guides/event-loop-timers-and-nexttick/

BabyElias avatar Oct 04 '22 05:10 BabyElias

@benhalverson should we add back the blocking-vs-non-blocking learn page? Or should we update the text not to include references to blocking vs non-blocking? Or should we update this link to redirect to an external documentation source?

ovflowd avatar Oct 04 '22 09:10 ovflowd

I believe we finally fixed all the broken links, so I will close this. If we by any chance find another broken link we can reopen this issue.

ovflowd avatar Nov 02 '22 15:11 ovflowd