node

node copied to clipboard

build: fix pointer compression builds

4

### build: fix pointer compression builds - Remove usage of deprecated V8::InitializeSandbox(). - External code space and pointer compression shared cage must be enabled when pointer compression builds are enabled....

joyeecheung

Proposal: generic key derivation function for crypto

11

### What is the problem this feature will solve? The crypto library currently lacks a generic key derivation function similar to [OpenSSL's `EVP_KDF` methods](https://wiki.openssl.org/index.php/EVP_Key_Derivation) and resembling [WebCrypto's `deriveKey`](https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/deriveKey). This proposal...

ranisalt

cli: add support to bin scripts

1

### Description This PR makes `node --run ` run commands from the package’s bin section as well. If the command is in both scripts and bin, the version in scripts...

IlyasShabi

test_runner: emit test:watch:restarted event on watched file changes

11

The goal of this PR is to add a `test:watch:restarted` event to signal to the reporter that some tests have restarted while in watch mode. This will enable a trivial...

JacopoPatroclo

src: remove NonCopyableMaybe

2

I added this class in 823d86c47ce15fba8875fcebd412593b02aab362 in 2018 when we did not yet use `std::optional`. The last uses were removed in 5b9bf39b47afcf26aaad810eec2ba8bdff904d4c, so remove it. Refs: https://github.com/nodejs/node/pull/24234 Refs: https://github.com/nodejs/node/pull/55368

tniessen

watch: fix watch args not being properly filtered

2

Currently the [logic for filtering out watch related flags](https://github.com/nodejs/node/blob/25842c5e35efb45df169e591c775a3c4f853556d/lib/internal/main/watch_mode.js#L42-L55) before passing them to the watch target script is flawed, as it includes any flag (starting with `-`) that follows a...

dario-piotrowicz

src: simplify is_callable by making it a concept

1

Using a C++20 `concept` here makes `is_callable` much simpler than relying on SFINAE. It is equivalent for function types, `std::function`, lambdas, and classes with `operator()`, regardless of argument or return...

tniessen

doc: call out potentially unexpected results when mocking and testing synchronous callback-based APIs

1

This PR fixes https://github.com/nodejs/node/issues/58161. When mocking synchronous callback-based APIs, the `MockFunctionContext` tracking mock calls won't be register until after the mock function finishes execution. Tests exercising callback-based code will likely...

filmaj

node-api: use WriteV2 in napi_get_value_string_utf16

3

Since `String::Write()` is deprecated, use `String::Write2()` instead. That requires us to compute the correct number of characters ahead of time but removes the need for dealing with the return value.

tniessen

src: use String::WriteV2() in TwoByteValue

1

Since `String::Write()` is deprecated, use `String::WriteV2()` instead.

tniessen